Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating parser to regex #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updating parser to regex #7

wants to merge 3 commits into from

Conversation

Pancakem
Copy link
Contributor

Closes #6

@zacck-zz
Copy link
Member

Nice work @Pancakem

@Pancakem
Copy link
Contributor Author

We can get this merged. I am moving to the tests. @zacck @omanimo

@zacck-zz
Copy link
Member

@Pancakem would you mind writing down what this does and how like a paragraph should be cool so we have a record and it can be maintained later

@Pancakem
Copy link
Contributor Author

@Pancakem would you mind writing down what this does and how like a paragraph should be cool so we have a record and it can be maintained later

On this PR?

@zacck-zz
Copy link
Member

@Pancakem yeah in the description works, although maybe you can document it in the actual code

@Pancakem
Copy link
Contributor Author

@Pancakem yeah in the description works, although maybe you can document it in the actual code

Let me put it in the code.

@zacck-zz zacck-zz self-requested a review July 15, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacck-zz zacck-zz Awaiting requested review from zacck-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update parser using regex
2 participants
@Pancakem @zacck-zz